Skip to content

addressed issue #236 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SikandarEjaz merged 1 commit into from
Jun 8, 2026
Merged

addressed issue #236 #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Middleware/src/main/java/ca/concordia/encs/citydata/core/configs/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,12 @@ public AuthenticationManager authManager(UserDetailsService userDetailsService,
@Bean
public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
return http.cors(Customizer.withDefaults()).csrf(AbstractHttpConfigurer::disable)
.authorizeHttpRequests(auth -> auth.requestMatchers("/authenticate", "/home", "/health/ping",
"/producers/list", "/operations/list", "/routes/list", "/error", "/apply/sync", "/apply/async",
"/api/datasets/list").permitAll().anyRequest().authenticated())
.authorizeHttpRequests(
auth -> auth
.requestMatchers("/authenticate", "/home", "/health/ping", "/producers/list",
"/operations/list", "/routes/list", "/error", "/apply/sync", "/apply/async",
"/api/datasets/list", "/assets/logo.png")
.permitAll().anyRequest().authenticated())

@MinetteMeyo MinetteMeyo Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here is the addition of the logo and the dataset list right? It seems like all the code is changed

@SikandarEjaz SikandarEjaz Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only change here is addition of assets/logo.png to public list.

.oauth2ResourceServer(oauth2 -> oauth2.jwt(Customizer.withDefaults()))
.sessionManagement(session -> session.sessionCreationPolicy(SessionCreationPolicy.STATELESS)).build();
}
Expand Down
1 change: 0 additions & 1 deletion Middleware/src/main/java/ca/concordia/encs/citydata/core/controllers/HomepageController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ public String home() throws IOException {
var resource = new ClassPathResource("static/home.html");
return new String(resource.getInputStream().readAllBytes(), StandardCharsets.UTF_8);
}

}
Loading
Loading