Add prominent disconnected overlay to web terminal#121
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
Conversation
When the WebSocket connection drops, a full-terminal overlay now appears with 50% black opacity and large red "DISCONNECTED" text centered on it. The overlay appears immediately on disconnect and disappears when the connection is re-established. The small status indicator in the toolbar remains as a secondary signal. Fixes #77
Author
Visual verificationConnected (left) vs Disconnected (right) overlay rendering: Message: Body cannot be blank, Locations: [{Line:1 Column:49}] |
Author
Review feedback addressedAll 3 high-priority items from the upstream PR review are resolved: 1.
2. Overlay as sibling, not child (commit 95cd91b)
3. Reactivity for overlay condition (commit a045251)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointer-events: noneso the overlay doesn't interfere with terminal interaction during brief disconnectsVisual comparison
Connected state (left) vs Disconnected state (right):
The disconnected overlay dims the terminal content with a semi-transparent black layer and shows "DISCONNECTED" in large red text, making the connection loss immediately obvious.
(Screenshot rendered from a mockup showing the overlay CSS applied to terminal content)
Implementation
Single file change in
web/src/components/pages/terminal.ts:.disconnected-overlayand.overlay-textCSS styles.terminal-containerthat renders when!this.connected && this.terminal(only shown after terminal has initialized, not during initial loading)Test plan
Fixes #77