fix: resolve workspace file browser to groves/ instead of projects/#132
Closed
scion-gteam[bot] wants to merge 2 commits into
Closed
fix: resolve workspace file browser to groves/ instead of projects/#132scion-gteam[bot] wants to merge 2 commits into
scion-gteam[bot] wants to merge 2 commits into
Conversation
The Hub UI file browser was showing the wrong directory contents. The hubManagedProjectPath() function resolved workspace paths to ~/.scion/projects/<slug>/ (project metadata) instead of ~/.scion/groves/<slug>/ (the actual git checkout mounted as /workspace in agents). Reverse the lookup priority: check groves/ first, fall back to projects/, and default to groves/ when neither has content. Fixes #130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hubManagedProjectPath()now resolves to~/.scion/groves/<slug>/(the actual git checkout mounted as/workspacein agents) instead of~/.scion/projects/<slug>/(which only contains project metadata and Telegram plugin downloads)groves/has no workspace content, falls back toprojects/for backward compatibilitygroves/path instead ofprojects/Fixes #130
Test plan
TestHubManagedProjectPath— default path now resolves togroves/TestHubManagedProjectPath_PrefersGrovesOverProjects— when both dirs have content,groves/winsTestHubManagedProjectPath_FallsBackToProjectsWhenGrovesEmpty— falls back toprojects/whengroves/has no real contentTestHubManagedProjectPath_DefaultsToGrovesWhenNeitherHasContent— defaults togroves/when neither has content