Skip to content

Fix agent list task overflow and unify action buttons #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scion-gteam wants to merge 3 commits into from
Closed

Fix agent list task overflow and unify action buttons #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e154142
Fix agent list task overflow and unify action buttons
ptone Jun 4, 2026
a5ec34a
Fix agent list task overflow and unify action buttons
ptone Jun 4, 2026
6b7bab3
Add before/after screenshots for PR review
ptone Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added web/.screenshots/after-card-icon-only.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/after-dark-card.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/after-dark-list.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/after-hover-card.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/after-hover-list.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/after-list-fixed.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/before-card-text-labels.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added web/.screenshots/before-list-overflow.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
281 changes: 129 additions & 152 deletions web/src/components/pages/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,31 @@ export class ScionPageAgents extends LitElement {
justify-content: flex-end;
}

/* Color-coded hover effects for action buttons */
.action-btn-danger::part(base):hover {
background: var(--scion-action-hover-danger-bg, rgba(239, 68, 68, 0.1));
border-color: var(--scion-danger-400, #f87171);
color: var(--scion-danger-600, #dc2626);
}

.action-btn-warning::part(base):hover {
background: var(--scion-action-hover-warning-bg, rgba(245, 158, 11, 0.1));
border-color: var(--scion-warning-400, #fbbf24);
color: var(--scion-warning-600, #d97706);
}

.action-btn-success::part(base):hover {
background: var(--scion-action-hover-success-bg, rgba(34, 197, 94, 0.1));
border-color: var(--scion-success-400, #4ade80);
color: var(--scion-success-600, #16a34a);
}

.action-btn-primary::part(base):hover {
background: var(--scion-action-hover-primary-bg, rgba(59, 130, 246, 0.1));
border-color: var(--scion-primary-400, #60a5fa);
color: var(--scion-primary-600, #2563eb);
}

.scope-toggle {
display: inline-flex;
border: 1px solid var(--scion-border, #e2e8f0);
Expand Down Expand Up @@ -812,9 +837,110 @@ export class ScionPageAgents extends LitElement {
`;
}

private renderAgentCard(agent: Agent) {
private renderActionButtons(agent: Agent) {
const isLoading = this.actionLoading[agent.id] || false;

return html`
${can(agent._capabilities, 'attach') ? html`
<sl-tooltip content="Terminal">
<sl-button
class="action-btn-primary"
variant="primary"
size="small"
href="/agents/${agent.id}/terminal"
?disabled=${!isTerminalAvailable(agent)}
aria-label="Terminal"
>
<sl-icon slot="prefix" name="terminal"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing}
${isAgentRunning(agent)
? can(agent._capabilities, 'stop') ? html`
${agent.harnessCapabilities?.resume?.support !== 'no' ? html`
<sl-tooltip content="Suspend">
<sl-button
class="action-btn-warning"
variant="warning"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'suspend')}
aria-label="Suspend"
>
<sl-icon slot="prefix" name="pause-circle"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing}
<sl-tooltip content="Stop">
<sl-button
class="action-btn-danger"
variant="danger"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'stop')}
aria-label="Stop"
>
<sl-icon slot="prefix" name="stop-circle"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing
: agent.phase === 'suspended'
? can(agent._capabilities, 'start') ? html`
<sl-tooltip content="Resume">
<sl-button
class="action-btn-success"
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'resume')}
aria-label="Resume"
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing
: can(agent._capabilities, 'start') ? html`
<sl-tooltip content="Start">
<sl-button
class="action-btn-success"
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'start')}
aria-label="Start"
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing}
${can(agent._capabilities, 'delete') ? html`
<sl-tooltip content="Delete">
<sl-button
class="action-btn-danger"
variant="default"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${(e: MouseEvent) => this.handleAgentAction(agent.id, 'delete', e)}
aria-label="Delete"
>
<sl-icon slot="prefix" name="trash"></sl-icon>
</sl-button>
</sl-tooltip>
` : nothing}
`;
}

private renderAgentCard(agent: Agent) {
return html`
<div class="agent-card">
<div class="agent-header">
Expand Down Expand Up @@ -849,83 +975,7 @@ export class ScionPageAgents extends LitElement {
${agent.taskSummary ? html` <div class="agent-task">${agent.taskSummary}</div> ` : ''}

<div class="agent-actions">
${can(agent._capabilities, 'attach') ? html`
<sl-button
variant="primary"
size="small"
href="/agents/${agent.id}/terminal"
?disabled=${!isTerminalAvailable(agent)}
>
<sl-icon slot="prefix" name="terminal"></sl-icon>
Terminal
</sl-button>
` : nothing}
${isAgentRunning(agent)
? can(agent._capabilities, 'stop') ? html`
${agent.harnessCapabilities?.resume?.support !== 'no' ? html`
<sl-button
variant="warning"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'suspend')}
>
<sl-icon slot="prefix" name="pause-circle"></sl-icon>
Suspend
</sl-button>
` : nothing}
<sl-button
variant="danger"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'stop')}
>
<sl-icon slot="prefix" name="stop-circle"></sl-icon>
Stop
</sl-button>
` : nothing
: agent.phase === 'suspended'
? can(agent._capabilities, 'start') ? html`
<sl-button
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'resume')}
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
Resume
</sl-button>
` : nothing
: can(agent._capabilities, 'start') ? html`
<sl-button
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'start')}
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
Start
</sl-button>
` : nothing}
${can(agent._capabilities, 'delete') ? html`
<sl-button
variant="default"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${(e: MouseEvent) => this.handleAgentAction(agent.id, 'delete', e)}
>
<sl-icon slot="prefix" name="trash"></sl-icon>
</sl-button>
` : nothing}
${this.renderActionButtons(agent)}
</div>
</div>
`;
Expand Down Expand Up @@ -964,8 +1014,6 @@ export class ScionPageAgents extends LitElement {
}

private renderAgentRow(agent: Agent) {
const isLoading = this.actionLoading[agent.id] || false;

return html`
<tr>
<td>
Expand All @@ -989,78 +1037,7 @@ export class ScionPageAgents extends LitElement {
</td>
<td class="actions-cell">
<span class="table-actions">
${can(agent._capabilities, 'attach') ? html`
<sl-button
variant="primary"
size="small"
href="/agents/${agent.id}/terminal"
?disabled=${!isTerminalAvailable(agent)}
>
<sl-icon slot="prefix" name="terminal"></sl-icon>
</sl-button>
` : nothing}
${isAgentRunning(agent)
? can(agent._capabilities, 'stop') ? html`
${agent.harnessCapabilities?.resume?.support !== 'no' ? html`
<sl-button
variant="warning"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'suspend')}
>
<sl-icon slot="prefix" name="pause-circle"></sl-icon>
</sl-button>
` : nothing}
<sl-button
variant="danger"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'stop')}
>
<sl-icon slot="prefix" name="stop-circle"></sl-icon>
</sl-button>
` : nothing
: agent.phase === 'suspended'
? can(agent._capabilities, 'start') ? html`
<sl-button
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'resume')}
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
</sl-button>
` : nothing
: can(agent._capabilities, 'start') ? html`
<sl-button
variant="success"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${() => this.handleAgentAction(agent.id, 'start')}
>
<sl-icon slot="prefix" name="play-circle"></sl-icon>
</sl-button>
` : nothing}
${can(agent._capabilities, 'delete') ? html`
<sl-button
variant="default"
size="small"
outline
?loading=${isLoading}
?disabled=${isLoading}
@click=${(e: MouseEvent) => this.handleAgentAction(agent.id, 'delete', e)}
>
<sl-icon slot="prefix" name="trash"></sl-icon>
</sl-button>
` : nothing}
${this.renderActionButtons(agent)}
</span>
</td>
</tr>
Expand Down
8 changes: 5 additions & 3 deletions web/src/components/shared/resource-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,10 +640,12 @@ export const listPageStyles = css`
}

.resource-table-container .task-cell {
max-width: 250px;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
max-width: 250px;
white-space: normal;
color: var(--scion-text-muted, #64748b);
font-size: 0.8125rem;
}
Expand Down