fix(hub): use deterministic UUID for plugin broker IDs#148
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
fix(hub): use deterministic UUID for plugin broker IDs#148scion-gteam[bot] wants to merge 1 commit into
scion-gteam[bot] wants to merge 1 commit into
Conversation
…ration The α migration remaps legacy string IDs like "plugin-broker-telegram" to deterministic UUIDv5 values using a fixed namespace. However, the plugin credential injection code in server_foreground.go still used the raw string format as the broker ID. After the migration, the store validates UUIDs, so CreateRuntimeBroker and GenerateAndStoreSecret both rejected the string ID with "invalid UUID", silently skipping credential injection. This caused broker plugins (telegram, googlechat) to start without hub_url or broker_id, dropping all inbound messages after a hub restart. Fix: generate the broker ID using the same UUIDv5(namespace, legacy_id) derivation as the migration, so the ID matches what's already in the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin-broker-telegram) to deterministic UUIDv5 values, the plugin credential injection code still used the raw string formatCreateRuntimeBrokerandGenerateAndStoreSecretboth fail silently, skipping hub credential injectionhub_urlorbroker_id, dropping all inbound messagesFix: derive the broker ID using the same
UUIDv5(namespace, legacy_id)as the α migration.Test plan
hub_url=https://gteam.projects.scion-ai.devandbroker_id=7200a43f-...scion message→ delivered on Telegram → reply received