feat: auto-prefix bare email recipients with user:#160
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
Conversation
Instead of returning an error when a bare email address (without the "user:" prefix) is passed as a recipient to `scion message`, auto-resolve it as a user recipient by internally prepending "user:". This matches the existing behavior of classifyRecipient() for group (set[]) recipients. Fixes #159
Owner
|
Merged upstream — PR GoogleCloudPlatform#335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scion messageinstead of returning an errorscion message someone@example.com "hello"now works the same asscion message user:someone@example.com "hello"classifyRecipient()which already handles bare emails inset[]groupsFixes #159
Test plan
TestBareEmailRecipientAutoPrefix— bare emails (with and without subdomain) are accepted withoutuser:prefixuser:email@example.comcontinues to workcmd/andpkg/messages/tests pass