Conversation
- Implement tests for slash command completions and input handling. - Validate mouse interactions for scrolling and selecting history. - Test command execution for /ask, /plan, and /run commands. - Ensure proper state management during command execution and history navigation. - Verify rendering behavior for output lines with folded details. - Check initial state for suggestions on empty input.
- 在 Command 结构中添加 Metadata 字段，用于存储命令的扩展注解。 - 实现命令调度钩子，支持将特定命令自动重定向到 agentline。 - 增加 agentline 命令的初始化参数支持，允许直接执行命令。 - 更新相关测试用例，确保新功能的正确性。 - 添加示例文档，展示如何使用新功能。
kooksee
commented
Mar 25, 2026
kooksee
commented
Mar 25, 2026
kooksee
commented
Mar 25, 2026
kooksee
commented
Mar 25, 2026
kooksee
commented
Mar 26, 2026
kooksee
commented
Mar 26, 2026
kooksee
commented
Mar 26, 2026
- Introduced JavaScript/TypeScript and Shell PR review supplementary guidelines to enhance code review processes. - Established a general PR review guideline document to standardize feedback and comment resolution in pull requests. - Updated PR review round prompt to support automatic identification of PRs and execution of full review rounds. - Created a documentation catalog for easier navigation of project documents. - Added a detailed code review guide in Chinese, outlining best practices and issue classification for effective code reviews. - Implemented a unified PR comment template to streamline issue reporting in GitHub PRs. - Developed a PR review rubric to guide Copilot in conducting structured, round-based reviews.
kooksee
commented
Mar 26, 2026
Contributor
Author
kooksee
left a comment
kooksee
left a comment
There was a problem hiding this comment.
补充一条新增兼容性问题（已按行级定位并去重后发布）。
kooksee
commented
Mar 26, 2026
Contributor
Author
kooksee
left a comment
kooksee
left a comment
There was a problem hiding this comment.
Round 0-4 审查结论（自动全量）
已完成 Round 0 -> Round 4 审查。当前 PR 规模较大（77 files, +15675/-391），核心风险仍集中在命令分发前的环境预加载兼容性；此外发现一项测试覆盖缺口会降低后续回归保护能力。
主要风险
- 已存在未解决 Blocker：
Invocation.Run在命令定位前无条件预解析--env/-e，可能劫持业务子命令本地-e语义（见现有讨论线程）。 - 测试覆盖未覆盖该兼容性边界，回归风险仍高。
Review Conclusion
- Statistics: Blocker=1（沿用现有未决）, Major=1（本次新增）, Minor=0, Nit=0
- Risks: 子命令 flag 语义兼容性回归，可能导致 CLI 行为在发布后出现非预期变更。
- Verdict:
⚠️ 需要修改
kooksee
commented
Mar 26, 2026
Contributor
Author
kooksee
left a comment
kooksee
left a comment
There was a problem hiding this comment.
复审结论（针对最新提交 37da31adca4b8124c7ba1d86184c1f584caa5fe8）：
- 本次新增提交仅涉及审查规范与文档模板（5 files, +13/-31），未触及
command.go/env_preload.go等运行时逻辑。 - 复审未发现新的行级问题，因此未新增行级评论。
- 仍需关注既有兼容性与补测问题（复用已有评论链接）：
command.go兼容性风险（命令定位前预解析 env）：#8 (comment)command_test.go补测建议（子命令本地-e不被劫持）：#8 (comment)
建议在上述两项闭环后再考虑合入。
kooksee
commented
Mar 26, 2026
Contributor
Author
kooksee
left a comment
kooksee
left a comment
There was a problem hiding this comment.
补充“整个 PR”模块深审结果：
本轮新增覆盖模块：cmds/webttycmd、internal/webui、internal/mcpserver、cmds/readlinecmd、cmds/richlinecmd、internal/gitshell。
新增发现 2 条安全问题（均为本地服务被跨站页面驱动的风险）：
webtty未对/ws与文件管理接口做来源校验或最小鉴权；webui两个 WebSocket 入口同样未做来源校验或会话令牌校验。
其余模块本轮未发现可稳定复现的新阻断问题。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.