UI Design Stage 2#39
Open
IshaGupta18 wants to merge 7 commits into
Open
Conversation
Member
|
Hi @IshaGupta18, nice work. I guess we should now slowly start to deprecate the old js code write in the new code as we now have after the merging of this very big pr #29. What do you say? |
Collaborator
Author
|
That's what I have done in this PR. However, I am facing a small problem
here as you can see. Could you have a look at the code in this PR and see
why the CsvParser is being returned as null, although it works fine in
handleFileSelectLocal?
…On Tue, Jun 11, 2019, 1:01 AM Naman Gupta ***@***.***> wrote:
Hi @IshaGupta18 <https://github.com/IshaGupta18>, nice work. I guess we
should now slowly start to deprecate the old js code write in the new code
as we now have after the merging of this very big pr #29
<#29>. What do you
say?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39?email_source=notifications&email_token=AJXHQZ64FND3EUNIC5JY47TPZ2TY5A5CNFSM4HWMZRYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXK7QKY#issuecomment-500561963>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ3HBOCKE3LNQCIJAV3PZ2TY5ANCNFSM4HWMZRYA>
.
|
Member
|
The pr is showing changes in the parsing.js. |
Member
|
I see you made the changes in |
Collaborator
Author
|
Oh okay, I will do these changes in src and make a fresh PR, although could
you please have a look at this bug, since the code is same in both the
places? Thank you!
…On Tue, Jun 11, 2019, 1:16 AM Naman Gupta ***@***.***> wrote:
I see you made the changes in dist/PublicLab.Grapher.js. We don't make
changes to files in dist folder. These are generated using Babel and
Browserify itself when we run npm run build command which sees the src/
folder for any change and transcompile the es6 code to es5 code in dist/.
Please don't make changes to dist/. Make changes to src/ while running npm
run install all the changes will be automatically done in dist/ files.
I am writing a readme about this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39?email_source=notifications&email_token=AJXHQZ62XOCJF6KYSR6TQG3PZ2VSXA5CNFSM4HWMZRYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLAZUQ#issuecomment-500567250>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZY7LK2URA2SQCCPRVTPZ2VSXANCNFSM4HWMZRYA>
.
|
Member
|
This feature is not implemented yet. I have opened the issue #40 |
Closed
Member
|
@IshaGupta18 thank you! I suppose you solved this elsewhere. If so, may I close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the further development in:
UI Design
Enabling some of the import options with the latest code
This will also close #38
However, I am facing a small problem in the string parsing functionality:
Could anyone suggest why the
CsvParserobject is coming out to be null here? @namangupta01 @Souravirus @jywarren @IgorWilbert Thanks a lot!