Skip to content

fixes linting errors#92

Open
ovpv wants to merge 5 commits into
publiclab:mainfrom
ovpv:es-lint-fix
Open

fixes linting errors#92
ovpv wants to merge 5 commits into
publiclab:mainfrom
ovpv:es-lint-fix

Conversation

@ovpv

@ovpv ovpv commented Oct 31, 2019

Copy link
Copy Markdown

Fixes #50

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers or the user who published the issue for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help!

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@pythongiant pythongiant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ovpv you have merge conflicts in your PR. check them out? rest LGTM

@ovpv

ovpv commented Dec 14, 2019

Copy link
Copy Markdown
Author

Hi @ovpv you have merge conflicts in your PR. check them out? rest LGTM

Hey @pythongiant , I have resolved the conflicts. Please check and let me know if there are any further issues.

@ovpv

ovpv commented Dec 17, 2019

Copy link
Copy Markdown
Author

hey @pythongiant , After the latest pull from the main branch, The build checks are failing. I am not sure why that's happening? can you help?

@pythongiant

Copy link
Copy Markdown
Contributor

Looks like checks are passing now, Good work

@ovpv

ovpv commented Jan 6, 2020

Copy link
Copy Markdown
Author

Looks like checks are passing now, Good work

hey @pythongiant , Does this usually take this much time to merge a PR in this repository or is it on hold due to some issue? if so please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve linting errors

2 participants