✨ 2.0#770
Open
johangirod wants to merge 115 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 32f48a0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for publicodes-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@publicodes/cli
@publicodes/codemod
publicodes
@publicodes/forms
@publicodes/react-ui
@publicodes/rest-api
@publicodes/tools
commit: |
johangirod
force-pushed
the
2.0
branch
16 times, most recently
from
b9020b1 to
a8a76f5
Compare
johangirod
force-pushed
the
2.0
branch
3 times, most recently
from
d6e12cb to
4093e3c
Compare
In order to avoid to regenerate the bin/compiler/compiler-<os> bin in the cli package, we use symbolic link instead.
Use a Makefile to centralize commands to install deps, build, run test and benchmarks. For JS runtime tests, we now use the `_build/default` binary path to significatly speed up the suite test execution. (We still use the @publicodes/cli one in the CI though).
Using bun directly was wrong, but this yarn command also is broken because this directory is not a yarn project. Run it in the example directory to fix this.
Gerrit reviews: - [fix(ci): correctly run tests](https://review.gerrithub.io/c/1235959) - [refactor(compiler): simplify the Typed_tree.from_ast pass](https://review.gerrithub.io/c/1235958) - [feat(compiler): use explicit NotDefined and NotApplicable values](https://review.gerrithub.io/c/1235957) - [refactor(compiler): move templating logic in ./hashed_tree](https://review.gerrithub.io/c/1235956)
Change-Id: Ia66312cecdd15a894b8feccd75d488c66a6a6964
Change-Id: I2891a1be125a548018d1183019a839986a6a6964
In this situation, some internal would lack a type, and it is okay and expected. Let's not warn in this situation. Change-Id: Ic42acf10799d7e725d8a54873461f1926a6a6964
Change-Id: Ie69aacb3396fbb9aee77d84f1a6df6a96a6a6964
We plan to build a debug interface. Now that the evaluation frontends are separated from the Publicodes models, we have to find a way to reconciliate evaluated values and resolved rule trees. To achieve that we now build a hashmap of the evaluated values while returning them. The keys will reflect the target nodes from the resolved Publicode models. The keys are digest hashes of the positions in the model files. We build them with the Jingoo models. We will also build them while constructing the resolved Publicode models trees later. The new option value "trace" can enable the trace building. We thought about refactoring the $ret function call in the runtimes themselves, but as we still have to return the main rule value from the main methods, I think it is legitimate to keep all of them here. Also this would not really simplify the code, because the most intrusive part, the ids, remains in the main method. I think we could keep $ret and runtime function separated for now. Change-Id: Ib6f560088259f3d6b145ddcb7dea693b6a6a6964
Change-Id: Id3368cda3a15a40bc7054578e1af86e56a6a6964
Change-Id: Ieb8d62248b412c8de0730effe4a198a06a6a6964
"rule" is used too much here. "node" make more sense as it is a tree. "rule" is kept for the output rules. Change-Id: I63db77f295b798521c5c5688b43a8cf56a6a6964
Change-Id: Ie57eea8c55ff434860d14183ea711a506a6a6964
Stdin inputs can be openned again to display contextual hints. Let's consider them as empty_files to display <No source available>. Change-Id: If743739ce55d0589411a1cf0c3aa50e56a6a6964
For this to works we sometime have to re-order some module opennings, to make sure Base.Option and Base.Result are openned later than Utils. Change-Id: I66bc8f3c76ff3f1e483b61e31d9c79046a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soon...
👉 Voir l'avancement : Publicodes 2