Open
Conversation
micprog
force-pushed
the
michaero/pulp_wrapper
branch
from
7f6210f to
e4b241a
Compare
micprog
force-pushed
the
michaero/pulp_wrapper
branch
from
e4b241a to
8f0efe7
Compare
micprog
force-pushed
the
michaero/pulp_wrapper
branch
2 times, most recently
from
a2723f8 to
90baeb8
Compare
micprog
force-pushed
the
michaero/pulp_wrapper
branch
from
90baeb8 to
e7e9de3
Compare
micprog
requested review from
Scheremo
and removed request for
SamuelRiedel and
paulsc96
micprog
changed the title
micprog
requested review from
SamuelRiedel,
alex96295,
colluca,
fischeti and
paulsc96
colluca
requested changes
Aug 22, 2024
Collaborator
colluca
left a comment
colluca
left a comment
There was a problem hiding this comment.
I assume the functionality has been separately tested, but the refactoring looks good to me. Just adding a few minor comments.
alex96295
approved these changes
Aug 22, 2024
alex96295
left a comment
alex96295
left a comment
There was a problem hiding this comment.
Looks good, for final LGTM needs basic in-system test with at least one adapter variant (e.g. in safety island)
colluca
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an OBI-compatible wrapper for the icache, converting the OBI request into the
snitch_icachefetch protocol. While multiple adapters are added, only one was properly tested.This allows using the icache in systems such as the pulp_cluster and safety_island, with cores such as ibex or cv32e40p.