Include DEFAULT_AUTHENTICATION_CLASSES when token auth is disabled#2363
Open
dkliban wants to merge 1 commit into
Open
Include DEFAULT_AUTHENTICATION_CLASSES when token auth is disabled#2363dkliban wants to merge 1 commit into
dkliban wants to merge 1 commit into
Conversation
When TOKEN_AUTH_DISABLED=True, ContainerRegistryApiMixin only used RegistryAuthentication (Basic auth), ignoring any custom backends configured in DEFAULT_AUTHENTICATION_CLASSES. Now includes both RegistryAuthentication and all configured default authentication classes, allowing deployments to use custom auth backends alongside standard Basic auth for container registry operations. Fixes pulp#2362 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOKEN_AUTH_DISABLED=True,ContainerRegistryApiMixin.authentication_classesnow includesDEFAULT_AUTHENTICATION_CLASSESalongsideRegistryAuthenticationRegistryAuthenticationremains first for backwards compatibilityFixes #2362
Test plan
DEFAULT_AUTHENTICATION_CLASSEScan authenticate to registry API whenTOKEN_AUTH_DISABLED=True