Allow publication of empty repositories

[hstct]

No description provided.

[quba42]

Things I spent some time considering;

• Naming of the new settings.
• Can the new indentation level in the publish function be avoided?
• Can something be done against the spaghetti style taking over publish?

My conclusion: I could not come up with any improvements that are not out of scope for this change.

I did find and fixed one more edge case: If both simple and structured is enabled, we should just rely on the simple metadata (which is always published) and not also publish fallback structured empty metadata. This also prevents failure/collision for the case STRUCTURED_EMPTY_REPO_DISTRIBUTION = "default". I then wen't and made that the new default so our new "default empty structured metadata" is more like our "default simple mode metadata" for consistency. It is a setting so users who don't like this can change it.

[patchback]

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6/pr-1424

Backported as #1455

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 3.8: 💔 cherry-picking failed — could not push

❌ Current GitHub App installation does not grant sufficient privileges for pushing to https://github.com/pulp/pulp_deb.git. Lacking Contents: write or Workflows: write permissions are known to cause this.

the underlying command output was:

$ git --git-dir /tmp/pulp--pulp_deb---3.8---4nycmxoh---PR-1424.git/.git --work-tree /tmp/pulp--pulp_deb---3.8---4nycmxoh---PR-1424.git -c user.email=45432694+patchback[bot]@users.noreply.github.com -c user.name=patchback[bot] -c diff.algorithm=histogram push --force-with-lease origin HEAD

[RETURN CODE]: 1

[OUTPUT]:


[STDERR]:

Backporting merged PR #1424 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pulp/pulp_deb.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.8/482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6/pr-1424 upstream/3.8

4. Now, cherry-pick PR Allow publication of empty repositories #1424 contents into that branch:

   $ git cherry-pick -x 482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6

   If it'll yell at you with something like fatal: Commit 482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Allow publication of empty repositories #1424 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.8/482bd0d45442ffe5f7f4335e8714d4c3e7fd7ea6/pr-1424

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.