Closed
Conversation
When attempting to delete the package in our current directory on windows, PPM must move out of the directory prior to deletion, otherwise Windows will report the resource is busy, with us in it
When upgrading a package, `getLatestSha` uses `git-utils` to create file handlers on the `git` DB. If we don't remove those Windows can fail to replace the contents of the package directory when upgrading
Member
Author
|
While in CI on windows we are down from 8 to now 6 failing specs, I'm happy to report that on my windows machine I'm now consistently getting fully passing test without any errors |
Seems Windows GHA tests have different values set for the temp env, and they even set them in a different user profile than we run tests in. Maybe there's permissions issues there?
on a modern git, on windows, completely fresh. This is now the second time this fixture has seemed to be the culprit for windows only failures. Lets just make a brand new one with the same contents
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After attempting development locally here again I ran into the longstanding pain point of the specs being abysmal on Windows.
Taking over an hour to run, and nearly all failing.
So going to finally take a serious shot at fixing this in the hopes of making further strides elsewhere in this repository.
Bugs/Items fixed changelog WIP:
test-git-repo.gitin the spec fixtures seems to be incompatible with Windows. 'Re-Hydrating' it and 're-dehydrating' it on a modern version of git allows it to be usable.ppm uninstall .PPM attempts to uninstall the entire current directory. If a user is on Windows this will fail silently (due to it being a call into localfs.js=>fs-plus=>rimraf). So if we instead realize we are deleting the directory we are currently in, and are on Windows, we moveprocess.cwdup one directory, then complete the deletion.