This repository was archived by the owner on Oct 27, 2025. It is now read-only.
Open
Conversation
This just creates wrong data. Old jobs that have been executed already and will not be executed again appear as jobs that will run at the current date (as their date is null). It should just be null instead like it is written in the persistence layer. No need for a fallback.
Contributor
|
@fermentfan As of now, deleting this value may cause side effects. Please post the specific case where deleting this is necessary in the issue, and I will take a look. |
Author
|
We simply query jobs like this: This returns a set of jobs, in which all jobs that originally have a null 'nextRunAt' in mongodb, have the fallback applied. |
Contributor
|
개인적인 사정으로 인해 프로젝트 관리에 어려움을 겪었습니다. 이번 달부터 점진적으로 프로젝트 관리를 재개할 계획입니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just creates wrong data. Old jobs that have been executed already and will not be executed again appear as jobs that will run at the current date (as their date is null). It should just be null instead like it is written in the persistence layer. No need for a fallback.
Is this behaviour important for some other logic?