Add support for environment overrides in ESC API#665
Open
seanyeh wants to merge 1 commit into
Open
Conversation
seanyeh
force-pushed
the
syeh/esc-draft-refs
branch
from
7b3ef94 to
323ce38
Compare
11 tasks
Comment on lines
+1076
to
+1080
| encoded, err := json.Marshal(overrides) | ||
| if err != nil { | ||
| return "", nil, fmt.Errorf("marshaling environment overrides: %w", err) | ||
| } | ||
| queryObj.EnvironmentOverrides = string(encoded) |
Contributor
There was a problem hiding this comment.
Is there a specific reason why we are sending an encoded json as query parameter instead of a json body?
Contributor
Author
There was a problem hiding this comment.
@borisschlosser for anonymous yaml open, we already send the environment definition as the body (as raw yaml), which makes it tricky to add anything else to the body. for the regular open, i kept the same for consistency
borisschlosser
requested changes
Jun 26, 2026
borisschlosser
left a comment
borisschlosser
left a comment
Contributor
There was a problem hiding this comment.
Waiting for backend discussions to resolve: https://github.com/pulumi/pulumi-service/pull/44449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: pulumi/pulumi#23562
Summary
Test changes
Risk
Rollback