Skip to content

Ability input bindings fix on client #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SneakyKittyGameDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ability input bindings fix on client #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...ryEnhancedInput/Source/ArcInventoryEnhancedInput/Private/ArcInvEnhancedInputSubsystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,26 +41,24 @@ int32 UArcInvEnhancedInputSubsystem::GetOrAddInputAction(UAbilitySystemComponent
return FoundAction;
}


UInputAction* InputAction = InBinder->InputAction;
int32 ActionBindingIndex = InputActionArray.Add(InputAction);
//Get the InputComponent for this ASC. It was created on the first binding, but if there are many bindings we need to reuse it
if (ASCInputComponents.Contains(ASC))
{
UInputAction* InputAction = InBinder->InputAction;
int32 ActionBindingIndex = InputActionArray.Add(InputAction);
//The EnhancedInputComponent can be null here legitimately. We only create these for input consuming clients
//However, the input index _does_ need to be synchronized. So if we don't have an input component here, still return that ID.
if (UEnhancedInputComponent* InputComponent = ASCInputComponents[ASC])
{
{
InputComponent->BindAction(InputAction, InBinder->StartTriggerEvent, ASC, &UAbilitySystemComponent::AbilityLocalInputPressed, ActionBindingIndex);

InputComponent->BindAction(InputAction, InBinder->EndTriggerEvent, ASC, &UAbilitySystemComponent::AbilityLocalInputReleased, ActionBindingIndex);
InputComponent->BindAction(InputAction, ETriggerEvent::Canceled, ASC, &UAbilitySystemComponent::AbilityLocalInputReleased, ActionBindingIndex);

}
return ActionBindingIndex;
}

return INDEX_NONE;
return ActionBindingIndex;
}

void UArcInvEnhancedInputSubsystem::RemoveInputAction(UAbilitySystemComponent* ASC, UArcInvEnhancedInputBinder* InBinder)
Expand Down