Conversation
joshcooper
reviewed
Apr 3, 2026
| - osx-14-arm64 | ||
| - osx-15-x86_64 | ||
| - osx-15-arm64 | ||
| - osx-26-x86_64 |
Contributor
There was a problem hiding this comment.
Will this break puppet 9 when we try to ship it? I suppose we have the same issue now. el-6-x86_64 is listed here, but we don't build/ship it in puppet 8. What does this repo do with foss_platforms and why isn't it pulled from the repo that produced the artifact https://github.com/puppetlabs/puppet-agent-private/blob/8.x/ext/build_defaults.yaml#L12 (so the list of packages to ship is versioned with the code)?
Contributor
There was a problem hiding this comment.
I'm not sure what all is controlled by it, but I know that it overrides what is in the build_defaults in some packaging code. There was a fairly recent discussion about it here: https://perforce.slack.com/archives/C04J7N6R761/p1771416311613629
isaac-jha
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
osx-26-x86_64to foss_platforms in builder_data.yamlNote: Due to a bug (PR puppet-private #130) affecting macOS 26 on Intel, we do not want to proceed with Puppet 9 nightly releases for this platform. However, Puppet 8.x is good to go for macOS 26 Intel.