Added support for checksum and checksum_value#1264
Open
rtuk wants to merge 2 commits into
Open
Conversation
This allows the module to download remote files (http) without triggering a change every time puppet runs
|
Hi @rtuk 👋 — thank you for your contribution to puppetlabs-apt! Could you please update the PR? |
# Conflicts: # manifests/keyring.pp
|
@rtuk could you please add some tests for the change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the module to download remote files (http) without triggering a change every time puppet runs
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
If you download a key from a keyserver (for example https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xd6811ed3adeeb8441af5aa8f4528b6cd9e61ef26), the keyring is downloaded every time
When providing the checksum of the contents of the expected file, a change is only triggered if the version on disk has changed.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)