wrapper for extension type: allow extension config from server.pp#1674
Open
ikonia wants to merge 1 commit into
Open
wrapper for extension type: allow extension config from server.pp#1674ikonia wants to merge 1 commit into
ikonia wants to merge 1 commit into
Conversation
remove white space linting linting alignment correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using the same merge pattern as server::roles to the role type, server::grants to the grant type this follows the same pattern creating the parameter extensions to access the extension type allowing extensions to be configured against database directly from server.pp
There is additional logic as there is a condition where you can define an extension against a database that has not yet been created (if the database has not been defined or server::database has not executed in this scenario there is logic to create the database first with the concept that there is no point trying to configure against an extension against a database you don't want to exist, so it is likely this database is either managed outside of the module, managed in the module but has not yet been properly configured (server::databases has not run) in which case the initial creation is done here and then the actual full database configuration will happen post the extension creation. This seems an acceptable way to handle this problem.
Additional Context
Add any additional context about the problem here.
following a proven pattern with roles -> server::roles , grants -> server::grants (and other variations that are still pending merge)
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)