PE-40175

[taikaa]

Prior to this commit the sshkey type didn't prohibit whitespace in the key property. This change now fails the resource type if a user adds space and adds a spec test

[mhashizume]

Thanks for the PR @taikaa ! I think we only want to check for leading or trailing whitespace for keys. IMO the documentation for this type is misleading, particularly:

The key attribute may not contain whitespace.

And

Key identifiers / comments, such as 'joescomputer.local' --- put these in the name attribute/resource title."

Seem like they were copy/pasted from ssh_authorized_keys. However, the file formats for /etc/ssh/ssh_known_hosts and ~/.ssh/authorized_keys are different.

We cannot put comments in the name attribute/resource title for sshkey the way we can with ssh_authorized_keys because the hostname needs to go there. As such, we probably don't want to be as strict about the contents of the keys itself and allow for comments.

[taikaa]

Hi @mhashizume thanks for your review! I modifying the test and failure condition. I also updated REFERENCE.md - once this has been reviewed I can squash my commits into one

[mhashizume]

I have a minor request about the REFERENCE.md but otherwise things look good!

[mhashizume]

Thanks @taikaa !

[kenyon]

A better PR title for the changelog would be good.

[mhashizume]

@kenyon You're right, I'll keep that in mind for next time