Skip to content

fix bug by referencing node_name instead of node#253

Open
biamandei wants to merge 2 commits intopuppetlabs:mainfrom
biamandei:fix_jvm_custom_property_type
Open

fix bug by referencing node_name instead of node#253
biamandei wants to merge 2 commits intopuppetlabs:mainfrom
biamandei:fix_jvm_custom_property_type

Conversation

@biamandei
Copy link
Copy Markdown
Collaborator

@biamandei biamandei commented Dec 20, 2022

This pull request fixes a bug in JVM Custom Property type caused by inconsistent variable naming: provider is referencing node_name instead of node

@biamandei biamandei requested a review from a team as a code owner December 20, 2022 12:10
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 20, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link
Copy Markdown

websphere_jvm_custom_property is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@biamandei biamandei force-pushed the fix_jvm_custom_property_type branch 2 times, most recently from d72e398 to e2c7070 Compare January 6, 2023 09:35
@chelnak chelnak added the bugfix label Jan 6, 2023
@chelnak chelnak self-assigned this Jan 6, 2023
@biamandei biamandei force-pushed the fix_jvm_custom_property_type branch 2 times, most recently from f4b2690 to 528ef44 Compare January 9, 2023 12:07
@biamandei biamandei force-pushed the fix_jvm_custom_property_type branch from 8f86ac3 to 0bd5e06 Compare July 13, 2023 12:49
@biamandei biamandei requested a review from bastelfreak as a code owner July 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants