Skip to content

Viewmodel added. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purvesh-d wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Viewmodel added. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions iOSTestApp/iOSTestApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@
E636554F29D4086F00307D70 /* String+Extension.swift in Sources */,
E636555529D4111700307D70 /* ContentView.swift in Sources */,
E636552329D34BAF00307D70 /* iOSTestAppApp.swift in Sources */,
E636554D29D34C3C00307D70 /* ContentViewModel.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
10 changes: 10 additions & 0 deletions iOSTestApp/iOSTestApp/ContentViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//

import Combine
import Foundation

class ContentViewModel: ObservableObject {

Expand All @@ -30,3 +31,12 @@ extension ContentViewModel {
}

}

extension String {
func isValidEmail() -> Bool {
let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64bugg}"

let emailTest = NSPredicate(format: "SELF MATCHES %@", emailRegEx)
return emailTest.evaluate(with: self)
}
}
Copy link
Copy Markdown

@github-actions github-actions bot Mar 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

There is a typo in the ContentViewModel.swift file.

In the isValidEmail() function, the regular expression has an extra "bugg" at the end. It should be removed to ensure that the email validation works correctly.

- let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64bugg}"
+ let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64}"

Please ask the developer to fix this issue before merging the code.

Copy link
Copy Markdown
Owner Author

@purvesh-d purvesh-d Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openai not understand

Copy link
Copy Markdown

@github-actions github-actions bot Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

@purvesh-d I apologize if my previous message was unclear. To fix the email validation issue, please replace the regular expression in line 30 of ContentViewModel.swift with the following:

let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64}"

This will remove the extra "bugg" at the end of the regular expression and ensure that the email validation works correctly.

Let me know if you have any further questions or concerns.

Copy link
Copy Markdown

@github-actions github-actions bot Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

There is a typo in the isValidEmail() function. The regular expression has an extra "bugg" at the end, which should be removed to ensure that the email validation works correctly. Please ask the developer to fix this issue before merging the code.

- let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64bugg}"
+ let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64}"

Please add this comment on the pull request for this file.