Skip to content

Viewmodel changes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purvesh-d wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Viewmodel changes #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c21a9
Viewmodel changes
purvesh-d Mar 31, 2023
43d23d7
Update main.yml
purvesh-d Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
review:
runs-on: ubuntu-latest
steps:
- uses: purvesh-d/OpenAIPRReviewAction@1.0.0
- uses: purvesh-d/OpenAIPRReviewAction@1.0.2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
Expand Down
5 changes: 5 additions & 0 deletions iOSTestApp/iOSTestApp/ContentViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class ContentViewModel: ObservableObject {
@Published var email = ""
@Published var needToShowAlert = false
@Published var errorText = ""
var apple = ""
var banana = ""

}

Copy link
Copy Markdown

@github-actions github-actions bot Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

This patch adds two new variables apple and banana to the ContentViewModel class.

Access modifiers have not been declared for these variables. Please add access modifiers to these variables.

Additionally, it would be good to ensure that these variables are named appropriately and serve a clear purpose in the code.

Please update the code accordingly and reply with the updated diff for further review.

Expand All @@ -29,4 +31,7 @@ extension ContentViewModel {
}
}

func getMultiplications(firstItem: Int, secondItem: Int, thirdItem: Int) {
return firstItem * secondItem * thirdItem
}
}
Copy link
Copy Markdown

@github-actions github-actions bot Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

This function has more than 2 parameters. I would recommend refactoring it to take fewer parameters, or splitting it into multiple functions if possible.

2 changes: 1 addition & 1 deletion iOSTestApp/iOSTestApp/String+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ extension String {
///
/// - Returns: is email is valid or not in boolean
func isValidEmail() -> Bool {
let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64}"
let emailRegEx = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64esasa}"

let emailTest = NSPredicate(format: "SELF MATCHES %@", emailRegEx)
return emailTest.evaluate(with: self)
Copy link
Copy Markdown

@github-actions github-actions bot Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

The email validation regular expression has been modified to include an invalid string "esasa". This should be removed. Please ask the developer to remove this change and resubmit the patch.

Expand Down