Skip to content

Multiplication addded. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purvesh-d wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Multiplication addded. #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions iOSTestApp/iOSTestApp/ContentViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,13 @@ extension ContentViewModel {
}

}

extension ContentViewModel {

func getMultiplication(firstNum: Int, secondNum: Int) -> Int {
if (firstNum != nil) {
return firstNum*secondNum
}

}
}
Copy link
Copy Markdown

@github-actions github-actions bot Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AIReviewRadar

Based on the provided diff, I have the following feedback:

  1. In the getMultiplication function, the firstNum parameter is an optional type (Int?). However, it is being used as a non-optional value in the implementation. This will result in a runtime error if firstNum is nil. To fix this issue, you can either change the parameter type to non-optional (Int) or add a check for nil before using firstNum.

  2. The getMultiplication function does not have any access modifiers. It is recommended to add an appropriate access modifier (e.g. public, private, internal) to clearly indicate the intended visibility of the function.

  3. The function name getMultiplication should be changed to calculateMultiplication or simply multiplication to follow Swift naming conventions.

  4. There is no error handling in the getMultiplication function. If the input values are invalid (e.g. firstNum is nil), the function will return an incorrect result or crash. It is recommended to add proper error handling to handle such cases.

  5. The code formatting seems to be inconsistent. For example, there are extra spaces after the opening parentheses in the if statement and missing spaces around the multiplication operator. It is recommended to follow consistent code formatting throughout the file.

Please make the necessary changes and let me know when you are ready for another review.