fix(api): preserve signJWT issuer claim#124
Merged
Conversation
Preserve payload iss claim in signJWT when present and add regression tests.
markwylde
changed the title
Use generateEdDSAKeyPair in the issuer tests and mock KEK-backed private key retrieval so the test setup matches signJWT runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signJWTnow preserves a provided payloadissclaim and only falls back tocontext.config.issuerwhen missing.Testing
npm run tidy(not available in this environment:biomeis not installed)npm run build(not available in this environment:tsc,vite, andjsdomare missing)