⚡ Bolt: Zero-copy decoding for SharedArrayBuffer #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Bolt: Zero-copy decoding for SharedArrayBuffer
💡 What:
Optimized data reading in
ShareableMapandShareableArrayby decoding directly from theSharedArrayBufferview instead of copying data to a temporary intermediate buffer.🎯 Why:
The previous implementation always copied data from the shared memory to a private buffer before decoding to support environments that couldn't decode directly from SAB. This added overhead (allocation + memcpy) to every read operation. Modern environments support decoding directly from SAB views.
📊 Impact:
Reduces memory allocation and copying overhead for all read operations (
get,readItem, iteration). For large datasets or frequent access, this significantly improves performance.Measurement:
Run benchmarks or read operations. The implementation includes a correctness fix for
NumberEncoderwhich was previously ignoringbyteOffset, enabling it to work with sliced views.Safety:
Added a
SUPPORTS_SAB_VIEWcheck to ensure the optimization is only used in environments that support it, falling back to the safe copy method otherwise.PR created automatically by Jules for task 6139085151123245300 started by @pverscha