Open
Conversation
sproshev
suggested changes
May 1, 2018
|
|
||
| public void setUp() { | ||
|
|
||
| fPlus3_5 = new Function1<Double, Double>() { |
There was a problem hiding this comment.
если это константы, зачем они в setUp?
| } | ||
|
|
||
| public void testPredicateBasic() { | ||
| assertEquals(true, Predicate.ALWAYS_TRUE.test(new Object())); |
|
|
||
| public void testPredicateBasic() { | ||
| assertEquals(true, Predicate.ALWAYS_TRUE.test(new Object())); | ||
| assertEquals(false, Predicate.ALWAYS_FALSE.test(null)); |
| public void testPredicateBasic() { | ||
| assertEquals(true, Predicate.ALWAYS_TRUE.test(new Object())); | ||
| assertEquals(false, Predicate.ALWAYS_FALSE.test(null)); | ||
|
|
| } | ||
| , "", Arrays.asList('a', 'b', 'c', 'd'))); | ||
| } | ||
| } |
There was a problem hiding this comment.
нигде не проверяются ? extends ..., ? super ...
Добавлены тесты на общность типов, расширены типы в некоторых местах.
sproshev
reviewed
May 25, 2018
|
|
||
| @Override | ||
| public boolean test(D0 arg) { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
эти сгенерированные todo оставлять не надо
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.