Conversation
added 16 commits
October 2, 2018 23:18
Добавлен скрипт для запуска. Добавлено сообщение о недостаточном количестве аргументов.
Добавлен базовый тест к нему. getChangedFiles и getDeletedFiles теперь только на файлы в текущем пути до корня смотрят.
После merge напоминание о том что надо сделать коммит.
sproshev
approved these changes
Nov 11, 2018
| public class BranchProblemException extends Exception { | ||
| String message; | ||
| public BranchProblemException(String s) { | ||
| message = s; |
There was a problem hiding this comment.
super(message), см конструкторы Exception
| .collect( | ||
| Collectors.joining("\n") | ||
| ) | ||
| ); |
| try { | ||
| revision = Integer.parseInt(args[1]); | ||
| res.add("Checkout to revision " + revision); | ||
| core.makeCheckout(revision - 1); |
There was a problem hiding this comment.
конвертация ревизии в представление для пользователя и обратно должна быть в одном месте (+/-1)
| res.add("IOException: " + e.getMessage()); | ||
| } catch (ArrayIndexOutOfBoundsException e) { | ||
| res.add("Lack of arguments"); | ||
| } |
There was a problem hiding this comment.
лучше ловить исключения как можно ближе к месту появления, например, ArrayIndexOutOfBoundsException может вылететь не по той причине, что будет написана в консоли
| } | ||
| inform.detachedHeadRevision = currDetachedPosT; | ||
|
|
||
| updateRepInformation(); |
Owner
Author
There was a problem hiding this comment.
Очищаются файлы, которые добавлены и которые удалены. Остальное сохраняется, как в настоящем git.
There was a problem hiding this comment.
в настоящем гите есть сборщик мусора )
|
|
||
| TreeMap<Integer, Integer> branchEnds = new TreeMap<>(); | ||
|
|
||
| ArrayList<Integer> numberOfStartedBranchesAtRevision = new ArrayList<>(); |
|
|
||
| inform.branchNumbers.remove(branchName); | ||
|
|
||
| updateRepInformation(); |
Owner
Author
There was a problem hiding this comment.
Здесь удаляется имя ветки, но коммиты остаются. В git вроде так.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.