shading: use morphology.footprint_rectangle((1, 3)) for 1x3 structuring element#233
shading: use morphology.footprint_rectangle((1, 3)) for 1x3 structuring element#233Omesh37 wants to merge 2 commits into
Conversation
|
@Omesh37 did you test this locally? pvanalytics isn't getting much work and this fix has uncovered another unrelated problem. |
|
@cwhanse Yes, I have tested using command |
|
@Omesh37 there's also an error related to converting a timedelta. If you don't have time/patience to track that down, I'll see if I can push to your PR. |
|
@cwhanse I suggest a possible fix to this that is: Storing pandas offset object and then returning the result. I have tested using: |
Fixes a TypeError / FutureWarning caused by differing scikit-image APIs. The structuring element creation in pvanalytics/features/shading.py now uses the modern
morphology.footprint_rectangle((1,3))call.Testing


FutureWarningfromskimage#226docs/api.rst.in
docs/whatsnewfor all changes. Includes link to the GitHub Issue with
:issue:`num`or this Pull Request with
:pull:`num`. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`).