Skip to content

DOC: BUG: fix analytical solar zenith formatting#582

Merged
wholmgren merged 2 commits into
pvlib:masterfrom
mikofski:patch-1
Sep 20, 2018
Merged

DOC: BUG: fix analytical solar zenith formatting#582
wholmgren merged 2 commits into
pvlib:masterfrom
mikofski:patch-1

Conversation

@mikofski

@mikofski mikofski commented Sep 19, 2018

Copy link
Copy Markdown
Member

pvlib python pull request guidelines

Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.

You may submit a pull request with your code at any stage of completion.

The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

  • Closes issue fix solarposition.solar_zenith_analytical parameter documentation #581
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

@wholmgren

Copy link
Copy Markdown
Member

Thanks @mikofski!

@wholmgren wholmgren merged commit 38a52b1 into pvlib:master Sep 20, 2018
@mikofski mikofski deleted the patch-1 branch September 23, 2018 07:43
@wholmgren wholmgren added this to the 0.6.1 milestone Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants