Skip to content

note and tests for disc relative vs absolute airmass#625

Merged
wholmgren merged 1 commit into
pvlib:masterfrom
wholmgren:disc
Nov 26, 2018
Merged

note and tests for disc relative vs absolute airmass#625
wholmgren merged 1 commit into
pvlib:masterfrom
wholmgren:disc

Conversation

@wholmgren

Copy link
Copy Markdown
Member
  • Closes DISC algorithm air mass #449
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren requested a review from cwhanse November 25, 2018 22:33
@wholmgren

Copy link
Copy Markdown
Member Author

@adriesse quick review requested.

@wholmgren wholmgren merged commit e5473bd into pvlib:master Nov 26, 2018
@wholmgren wholmgren deleted the disc branch November 26, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants