Skip to content

refactor: remove _CmapCombo thin subclass#262

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:remove-cmap-combo-subclass
Mar 27, 2026
Merged

refactor: remove _CmapCombo thin subclass#262
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:remove-cmap-combo-subclass

Conversation

@tlambert03
Copy link
Copy Markdown
Member

pyapp-kit/superqt#333 includes the fixes we had in our cmap combobox thin subclass here.

and also, our popup geometry overrides were flaky. This removes both and goes back to a stock combo

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.79%. Comparing base (a37e777) to head (9b7673e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   86.76%   86.79%   +0.03%     
==========================================
  Files          50       50              
  Lines        5742     5725      -17     
==========================================
- Hits         4982     4969      -13     
+ Misses        760      756       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 709f779 into pyapp-kit:main Mar 27, 2026
124 of 127 checks passed
@tlambert03 tlambert03 deleted the remove-cmap-combo-subclass branch March 27, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant