Skip to content

Avoid jupyter-rfb 1.0.2 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gselzer merged 2 commits into from
Apr 9, 2026
Merged

Avoid jupyter-rfb 1.0.2 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e6c1b
Avoid jupyter-rfb 1.0.2
gselzer Apr 8, 2026
c341216
Linting fixes
gselzer Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ dependencies = ["cmap>=0.5", "numpy>=1.24", "psygnal>=0.11.1", "pydantic>=2.10",
jupyter = [
"ipywidgets >=8.0.5",
"jupyter >=1.1",
"jupyter_rfb >=0.3.3",
# TODO: Enforce a minimum bound once >1.0.2 released
"jupyter_rfb >=0.3.3, <= 0.5.4",
# Note that this dep is only needed for Vispy, something like simplejpeg would work fine if just pygfx.
"glfw",
# Otherwise jupyter_rfb will use PNG, which is apparently slower
Expand Down Expand Up @@ -165,7 +166,7 @@ module = ["rendercanvas.*"]
follow_untyped_imports = true

[[tool.mypy.overrides]]
module = ["pygfx.*", "vispy.*", "wgpu.*", "glfw.*", "pylinalg.*", "qtpy.*", "ipywidgets.*", "IPython.*", "jupyter", "jupyter_rfb.*", "wx.*", "pytestqt.*"]
module = ["pygfx.*", "vispy.*", "wgpu.*", "pylinalg.*", "qtpy.*", "ipywidgets.*", "IPython.*", "jupyter", "jupyter_rfb.*", "wx.*", "pytestqt.*"]
ignore_missing_imports = true

[tool.pydantic-mypy]
Expand Down
2 changes: 1 addition & 1 deletion src/scenex/model/_nodes/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def _update_parent_children(node: Node, old_parent: Node | None = None) -> None:
new_parent._children.append(cast("AnyNode", node))
new_parent.child_added.emit(node)
if old_parent is not None and node in old_parent._children:
old_parent._children.remove(cast("AnyNode", node))
old_parent._children.remove(node)
old_parent.child_removed.emit(node)

@model_serializer(mode="wrap")
Expand Down
Loading