Skip to content

Ignore child events in adaptors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gselzer wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

Ignore child events in adaptors #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/scenex/adaptors/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,25 @@ def handle_event(self, info: EmissionInfo) -> None:
# Parent change events are handled by the parent adaptor.
return

arg = info.args[0]
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info.args[0] can raise IndexError if an emission occurs with no positional args (even if uncommon). Since this value is only used for logging and passing to the setter, consider guarding (e.g., check info.args length) or using a safe fallback before indexing.

Copilot uses AI. Check for mistakes.
try:
name = self.SETTER_METHOD.format(name=signal_name)
setter = getattr(self, name)
except AttributeError as e:
if len(info.path) > 1:
# A length 2+ path implies a child event bubbling up to a parent that
# doesn't have a handler for it. Let's just ignore it.
nested_name = "".join(f".{step.attr}" for step in info.path)[1:]
logger.debug(
"EVENT: %r ignored %s=%r (bubbling up, no handler)",
type(self),
nested_name,
arg,
)
return
logger.exception(e)
return

arg = info.args[0]
logger.debug("EVENT: %r -> %s=%r ", type(self), signal_name, arg)

try:
Expand Down
Loading