Qt: Handle middle mouse button#76
Merged
gselzer merged 1 commit intopyapp-kit:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Qt support for the middle mouse button so Qt behavior matches the existing wx/jupyter implementations.
Changes:
- Map
Qt.MouseButton.MiddleButtontoMouseButton.MIDDLEin the Qt event filter. - Expand the Qt mouse press test to cover left, right, and middle buttons via parametrization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/scenex/app/_qt.py |
Adds middle-button mapping in QtEventFilter.mouse_btn so Qt generates MouseButton.MIDDLE events. |
tests/app/test_qt.py |
Updates test_mouse_press to parametrically validate left/right/middle press events are emitted correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 88.08% 88.09%
=======================================
Files 64 64
Lines 3182 3184 +2
=======================================
+ Hits 2803 2805 +2
Misses 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow, the middle mouse button was handled for wx and jupyter but not for qt 😦