CameraController: implement BaseModel instead#77
Open
gselzer wants to merge 3 commits intopyapp-kit:mainfrom
Open
CameraController: implement BaseModel instead#77gselzer wants to merge 3 commits intopyapp-kit:mainfrom
gselzer wants to merge 3 commits intopyapp-kit:mainfrom
Conversation
There's no current use case for events on these classes, and it's causing issues downstream.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the camera controller models to no longer be event-emitting (EventedBase), aiming to avoid downstream issues caused by events on these classes.
Changes:
- Switched
CameraControllerinheritance fromEventedBasetopydantic.BaseModel. - Updated several docstring examples to use
import scenex as snxand fully-qualified names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 88.08% 88.09%
=======================================
Files 64 64
Lines 3182 3184 +2
=======================================
+ Hits 2803 2805 +2
Misses 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no current use case for events on these classes, and it's causing issues downstream.