Skip to content

refactor: use style-sheet free QToolButton for QCollapsible #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlambert03 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: use style-sheet free QToolButton for QCollapsible #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba4262b
feat: add _GhostToolButton for improved toggle button appearance in Q…
tlambert03 Mar 29, 2026
7e76116
fix: remove fixed size policy from _GhostToolButton for better layout…
tlambert03 Mar 29, 2026
08dd4c7
feat: match QPushButton typography for consistent header text size in…
tlambert03 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions src/superqt/collapsible/_collapsible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,41 @@
Qt,
Signal,
)
from qtpy.QtGui import QIcon, QPainter, QPalette, QPixmap
from qtpy.QtWidgets import QFrame, QPushButton, QSizePolicy, QVBoxLayout, QWidget
from qtpy.QtGui import QIcon, QPainter, QPaintEvent, QPalette, QPixmap
from qtpy.QtWidgets import (
QApplication,
QFrame,
QSizePolicy,
QStyle,
QStyleOptionToolButton,
QStylePainter,
QToolButton,
QVBoxLayout,
QWidget,
)


class _GhostToolButton(QToolButton):
"""Tool button that keeps a ghost appearance while checked."""

def __init__(self, parent: QWidget | None = None, *, title: str = "") -> None:
super().__init__(parent)
if title:
self.setText(title)
# Match QPushButton typography from main for consistent header text size.
self.setFont(QApplication.font("QPushButton"))
self.setCheckable(True)
self.setAutoRaise(True)
self.setToolButtonStyle(Qt.ToolButtonStyle.ToolButtonTextBesideIcon)

def paintEvent(self, a0: QPaintEvent | None) -> None:
if not a0:
return super().paintEvent(a0)
option = QStyleOptionToolButton()
self.initStyleOption(option)
option.state &= ~QStyle.StateFlag.State_On
painter = QStylePainter(self)
painter.drawControl(QStyle.ControlElement.CE_ToolButtonLabel, option)
Comment on lines +46 to +50
Copy link
Copy Markdown
Contributor

@Czaki Czaki Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to fix this, but this branch prevents from apply any style using stylesheet



class QCollapsible(QFrame):
Expand All @@ -39,13 +72,11 @@ def __init__(
self._is_animating = False
self._text = title

self._toggle_btn = QPushButton(title)
self._toggle_btn.setCheckable(True)
self._toggle_btn = _GhostToolButton(self, title=title)
self.setCollapsedIcon(icon=collapsedIcon)
self.setExpandedIcon(icon=expandedIcon)
self.setSizePolicy(QSizePolicy.Policy.Preferred, QSizePolicy.Policy.Maximum)

self._toggle_btn.setStyleSheet("text-align: left; border: none; outline: none;")
self._toggle_btn.toggled.connect(self._toggle)

# frame layout
Expand All @@ -68,7 +99,7 @@ def __init__(
_content.layout().setContentsMargins(QMargins(5, 0, 0, 0))
self.setContent(_content)

def toggleButton(self) -> QPushButton:
def toggleButton(self) -> QToolButton:
"""Return the toggle button."""
return self._toggle_btn

Expand Down
Loading