Revert "pin rust nightly until regression is fixed"#7393
Merged
reaperhulk merged 1 commit intomainfrom Jul 27, 2022
Merged
Conversation
Member
Author
|
Err, no, it was not merged yet. rust-lang/rust#98868 is the PR -- having opened this I'll just leave it around until that does merge though. |
alex
force-pushed
the
revert-7388-alex-patch-2
branch
from
1a0e045 to
8ad712b
Compare
Member
Author
|
Unfortunately while the Rust PR was merged, it doesn't look like the fix was enough: rust-lang/rust#98833 (comment) |
Member
Author
|
New PR to track rust-lang/rust#99711 |
This reverts commit e181382.
alex
force-pushed
the
revert-7388-alex-patch-2
branch
from
8ad712b to
ef35f96
Compare
reaperhulk
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7388
This is not fixed in rust master, opening now, we can merge once rust nightly is out.