fix: bugs in shutdown and add stop#30
Closed
colin-nolan wants to merge 7 commits intopycasbin:masterfrom
Closed
Conversation
|
|
colin-nolan
force-pushed
the
fix/clean-shutdown
branch
from
c9cf93c to
5066d15
Compare
colin-nolan
changed the title
stop method, and fixes bugs in shutdownstop
Author
|
Duplicated over in officialpycasbin/postgresql-watcher#4. |
Author
|
Closing as merged into officialpycasbin/postgresql-watcher#4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been observing issues with the watcher still holding connections to the database after it should have shutdown.
This PR:.
stopmethod to allow users to explictly shutdown the watcher, in mirror to the explictstartmethod.