Skip to content

fix: throw a TypeError if unexpected arguments are passed#207

Open
eric-wieser wants to merge 3 commits intopycontribs:mainfrom
eric-wieser:no-extra-kwargs
Open

fix: throw a TypeError if unexpected arguments are passed#207
eric-wieser wants to merge 3 commits intopycontribs:mainfrom
eric-wieser:no-extra-kwargs

Conversation

@eric-wieser
Copy link

@eric-wieser eric-wieser commented Mar 11, 2026

This also:

  • allows passing the executable argument
  • bans passing input and timeout, since these arguments were dangerously ignored.
  • does not always use shell=True semantics

@eric-wieser eric-wieser requested a review from ssbarnea as a code owner March 11, 2026 01:37
@eric-wieser eric-wieser changed the title Throw a TypeError if unexpected arguments are passed fix: throw a TypeError if unexpected arguments are passed Mar 11, 2026
@eric-wieser
Copy link
Author

@ssbarnea, it looks like there are CI issues unrelated to this PR, since the failure is:

error: command 'cc' failed: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant