Support OpenTelemetry logs SDK constructor changes#156
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesThis change adds Sequence Diagram(s)Included above in the hidden review stack artifact. Estimated code review effort: 2/5 Related issues: None specified. Related PRs: None specified. Suggested labels: patch, compatibility, logfire-node Suggested reviewers: Maintainers of Poem: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
16eec86 to
4262faa
Compare
Summary
Support both
BatchLogRecordProcessorconstructor shapes from@opentelemetry/sdk-logs.OpenTelemetry SDK logs
0.220.0changed the processor constructor from the legacy(exporter, config?)form to an options object containingexporter.@pydantic/logfire-nodealready allows a broad experimental SDK logs peer range, so this keeps current0.219.xinstalls working while allowing consumers to resolve0.220.xonce it clears the minimum release age policy.Changes
@pydantic/logfire-node.Validation
vp run @pydantic/logfire-node#testvp run @pydantic/logfire-node#typecheckpnpm run format-check