feat(search): debounced search on change for text-based fields#868
Open
cristianoliveira wants to merge 9 commits intov5-devfrom
Open
feat(search): debounced search on change for text-based fields#868cristianoliveira wants to merge 9 commits intov5-devfrom
cristianoliveira wants to merge 9 commits intov5-devfrom
Conversation
This commit adds a debounced search on change for text-based fields. It also adds mocks and unit tests for the search functionality. Detailed Changes: - Implementation: - Changed setValues method in withSearch to accept an immediate flag that triggers search without debounce. - Changed updateValue callback in FieldSearch and Renderer to pass the immediate flag. - Changed withSearch render method to use React.createElement. - Tests: - Added unit tests for withSearch setValues scheduling. - Added unit tests for FieldSearch immediate flag behavior.
…rity This commit renames the 'immediate' option to 'debounced' in search-related components to better reflect its behavior. The default search execution is now immediate, and debouncing must be explicitly requested.
| searchTools={searchTools} | ||
| /> | ||
| ); | ||
| return React.createElement(Component, { |
Contributor
Author
There was a problem hiding this comment.
to be able to create unit tests. Otherwise we need to rename from js to jsx
cristianoliveira
force-pushed
the
WPB-23520-ui-bug-search-url-input-triggers-too-many-requests
branch
from
46b742b to
2230c17
Compare
…arch-url-input-triggers-too-many-requests * origin/v5-dev: fix(pages): i18n and modal search polishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to https://wearezeta.atlassian.net/browse/WPB-23520
This commit adds a debounced search on change for text-based fields. It also adds mocks and unit tests for the search functionality.
Detailed Changes: