Skip to content

Make Pdop objects integrate with sympy#234

Draft
eric-wieser wants to merge 1 commit intopygae:masterfrom
eric-wieser:pdop-expr-2
Draft

Make Pdop objects integrate with sympy#234
eric-wieser wants to merge 1 commit intopygae:masterfrom
eric-wieser:pdop-expr-2

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Apr 20, 2020

No description provided.

@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 4 alerts when merging e5e3e07 into 409bb90 - view on LGTM.com

new alerts:

  • 3 for Conflicting attributes in base classes
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com

This comment has been minimized.

Sign in to view
@eric-wieser eric-wieser force-pushed the pdop-expr-2 branch 2 times, most recently from 950fd69 to 62cb405 Compare April 22, 2020 18:24
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 4 alerts when merging 62cb405 into 409bb90 - view on LGTM.com

new alerts:

  • 3 for Conflicting attributes in base classes
  • 1 for Module is imported with 'import' and 'import from'

eric-wieser
eric-wieser commented May 9, 2020
View reviewed changes
galgebra/_full_set.py
@@ -0,0 +1,50 @@
class FullSet(set):
Copy link
Member Author

@eric-wieser eric-wieser May 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this exists elsewhere in sympy. Will update to use that eventually.

Copy link
Member Author

@eric-wieser eric-wieser May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, sympy.sets.UniversalSet doesn't work here after all.

@eric-wieser
Make pdop and sdop instances native sympy objects
f001fab 
I'm not sure if this is correct yet, but it no longer crashes.
@lgtm-com
Copy link

lgtm-com bot commented May 25, 2020

This pull request introduces 5 alerts when merging f001fab into 7f57a09 - view on LGTM.com

new alerts:

  • 4 for Conflicting attributes in base classes
  • 1 for Module is imported with 'import' and 'import from'

@codecov
Copy link

codecov bot commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files          16       16           
  Lines        4217     4217           
=======================================
  Hits         3271     3271           
  Misses        946      946

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f57a09...f001fab. Read the comment docs.

@utensil utensil added this to the 0.6.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eric-wieser @utensil