Skip to content

Style tweaks to fix size inconsistencies#16

Merged
almarklein merged 3 commits intomainfrom
style-tweaks
Apr 2, 2026
Merged

Style tweaks to fix size inconsistencies#16
almarklein merged 3 commits intomainfrom
style-tweaks

Conversation

@almarklein
Copy link
Copy Markdown
Member

@almarklein almarklein commented Apr 2, 2026

Fixes the problem reported in vispy/jupyter_rfb#148

The size of the viewElement and wrapperElement are not equal, because of the border. I considered several approaches for drawing the border in an elegant way and settled on the following:

  • The wrapperElement has the border, together with the topElement (menubar).
  • The border-radius at the bottom is removed; there's no way to get the radius of the viewElement to match the radius of the inner-corner of the border.
  • Using css variables (never used them before!) to avoid setting the same measurement in multiple places. Now users can also tweak the appearance easier by setting a single value.
  • Also better vertical alignment of the title text.

@almarklein almarklein changed the title Style tweaks Style tweaks to fix size inconsistencies Apr 2, 2026
@almarklein almarklein merged commit 377cf2a into main Apr 2, 2026
3 checks passed
@almarklein almarklein deleted the style-tweaks branch April 2, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant