Skip script collisions with entry points#339
Open
Himanshuagrawal4 wants to merge 2 commits into
Open
Conversation
Contributor
|
"In the face of ambiguity, refuse the temptation to guess." |
Author
|
Thanks. I agree this is a policy choice. This PR follows one of the options from #315 and pip's current behavior: when a legacy script and generated entry point target the same script path, keep the generated entry point and skip the legacy script. Unlike pip, it emits a RuntimeWarning so callers can see that the wheel is ambiguous. Happy to change direction if maintainers prefer failing with a clearer error or exposing a policy knob instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.data/scriptsfiles that would overwrite an already generated entry point scriptCloses #315.
Validation
PYTHONPATH=src python -m pytest tests/test_core.pypython -m compileall -q src\installer