fix: replace deprecated posixpath.commonprefix() with startswith()#340
Open
frenzymadness wants to merge 2 commits into
Open
fix: replace deprecated posixpath.commonprefix() with startswith()#340frenzymadness wants to merge 2 commits into
frenzymadness wants to merge 2 commits into
Conversation
os.path.commonprefix() is deprecated in Python 3.15 and emits a DeprecationWarning. Replace all three usages with str.startswith() checks, which are also semantically more correct (commonprefix does character-level matching and can produce false positives for paths sharing a string prefix but not a directory boundary).
for more information, see https://pre-commit.ci
Member
|
Python docs mention using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.path.commonprefix() is deprecated in Python 3.15 and emits a DeprecationWarning. Replace all three usages with str.startswith() checks, which are also semantically more correct (commonprefix does character-level matching and can produce false positives for paths sharing a string prefix but not a directory boundary).
Without this,
TestInstall.test_skips_pycache_and_warnsfails with Python 3.15 because the code generated more warnings than expected.