Prefer native Linux tags before manylinux#1187
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux_*platform tags beforemanylinuxandmusllinuxon LinuxFixes #160.
Rationale
Issue #160 describes the expectation that a wheel built for the current Linux machine should be preferred over a more generic redistributable manylinux/musllinux wheel. The issue was reopened in 2024, and a maintainer signaled that the ordering change makes sense.
Validation
uv run --with pytest --with pretend pytest tests/test_tags.py -quv run --with ruff ruff check src/packaging/tags.py tests/test_tags.pyuv run --with ruff ruff format --check src/packaging/tags.py tests/test_tags.pyTMPDIR=$PWD/.tmp PIP_CACHE_DIR=$PWD/.tmp/pip-cache uv run --with nox nox -s lintuv run --with nox nox -s tests-3.13git diff --check origin/main...HEADNote: the first lint run hit the local
/tmpdisk quota while creating an isolated build environment. Re-running with a repo-localTMPDIR/PIP_CACHE_DIRpassed cleanly; the temporary cache was removed afterward.Assisted-by: OpenAI Codex