fix: add missing TYPE_CHECKING guard in tests#1197
Merged
Conversation
brettcannon
approved these changes
May 25, 2026
`typing_extensions` is not part of the test dependency group. When re-using an existing environment for Python 3.9 tests (default with the current noxfile), tests might fail at collection time because of the missing `typing_extensions` module.
henryiii
force-pushed
the
missing-type-checking-guard
branch
from
e93fdfc to
7286e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing_extensionsis not part of the test dependency group.When re-using an existing environment for Python 3.9 tests (default with the current noxfile), tests might fail at collection time because of the missing
typing_extensionsmodule. I did run into this.When looking at all
typing_extensionsusage,TypeGuardimport at runtime depended on the Python version so moved the whole block under theif TYPE_CHECKING:block for consistency.