Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "axios": "^1.11.0", | ||
| "i18next": "^25.3.4", | ||
| "i18next-browser-languagedetector": "^8.2.0", | ||
| "jszip": "^3.10.1", |
There was a problem hiding this comment.
I'm not really fond of generating zip on the frontend side. I would rather have in the backend. Maybe we can see with the delivery planning
fe51
left a comment
There was a problem hiding this comment.
Hi Alexis, thanks a lot for the PR !
First, It does not work for me using a Mac. With Chrome and Firefix its fails to download (It work 1 image as before) but not the zip.
It seems I get a CORS Error (see screenshot)
What do you need from me to help you fix whats could be wrong in my case ?
(running the project locally on your branch, connected to the production alerapi)
About 2 folders structure -> The solution you provide force windows user to use 7zip is that right ? Also, you are saying, it could work on Windows to have only one folder with all images (bboxes or not) without having to use 7zip ? According to your response, this leads us to at least a few strategies
- if 7zip is not necessary for 1 folder: could have 3 options associated with the download button arrow: current images, all images, all images with bbox
- Otherwise, we could consider testing with subfolders and 7zip needed and see how users behave/reacts (as long as I am not sure how often this feature will be used).
Happy to discuss it
03159dc to
1ac46d5
Compare
… zip, or all images with bounding boxes in zip)
1ac46d5 to
a1b4e14
Compare
|
Hi @fe51 👋 I made the requested changes. I also investigated those CORS errors your are getting. I assume you got them while not testing on your local machine. If that's indeed the case, here's the reason the zip download feature may fail on deployed environments:
If the images are hosted on S3, the only thing to do I can think of is to tell S3 to return the images with |
fe51
left a comment
There was a problem hiding this comment.
HI @Yoctoboy, thank you for the udpates !
Tested local this time no CORS issue !
Functional test is good for me if you just add camera name in file export in order to help firefighters.
Also, wondering, could it be an issue to have some /in file path ? delete or replace by a _?
Fixes #105
Loom:
https://www.loom.com/share/fc6b61960d024946b90b16e8141d85db